The R Project SVN R

Rev

Show changed files | Details | Compare with Previous | Blame | RSS feed

Filtering Options

Rev Age Author Path Log message Diff
71686 3533 d 21 h maechler /branches/tools4pkgs/ Create tools 4 packages branch  
71519 3574 d 13 h lawrence /trunk/src/main/ speedup matching of named arguments, PR#17157 (Pete Haverty)  
68947 4006 d 18 h ripley /trunk/src/ use https  
67595 4203 d 22 h ripley /trunk/src/ update copyright dates for 2014 changes  
67163 4245 d 10 h lawrence /trunk/src/main/ fix unused argument error message from match.call()  
67102 4254 d 13 h luke /trunk/src/ nextmethod argument patching optimization, from Tomas Kalibera  
66774 4304 d 19 h maechler /trunk/src/ A couple of not yet used (ifdef`ed), comments, and cosmetics  
65048 4541 d 14 h luke /trunk/ Merged in changes to support refrence counting changes; disabled for now.  
64258 4634 d 20 h ripley /trunk/src/ update comments  
64229 4636 d 20 h ripley /trunk/src/main/ avoid trying to allocate 0-length array on stack  
63181 4772 d 13 h ripley /trunk/src/ micro-manage R_alloc stack  
60800 5055 d 11 h ripley /trunk/src/ message has changed  
60799 5055 d 15 h ripley /trunk/src/ more use of ngettext  
59039 5217 d 22 h ripley /trunk/ use preferred form of 'R Core Team'  
51264 5981 d 23 h ripley /trunk/src/main/ clean up layout  
51259 5982 d 16 h ripley /trunk/ use standard matching for attr, on.exit and substitute  
51232 5985 d 10 h falcon /trunk/src/main/ Fix bug in matchArgs triggered by gc and finalizers

matchArgs was modifying the general purpose bits of SEXPs making up the
'formals' argument to keep track of ARGUSED. When gc is triggered
inside matchArgs, finalizer code can end up calling matchArgs on the
same function (hence same formals) resulting in corruption of gp bits.

This patch uses an int array allocated on the stack to keep track of
ARGUSED and avoids modifying the SEXPs in formals. In place modification
of SEXPs in supplied still occurs via ARGUSED/SET_ARGUSED, but should be
safe as long as no new allocating function calls are added to matchArgs.

A reproducible report of this bug was reported here:
https://stat.ethz.ch/pipermail/bioc-sig-sequencing/2010-March/000997.html		  
48789 6251 d 13 h luke /trunk/ Constructing error messages about unused arguments in calls to
closures no longer evaluates the arguments.		  
48029 6359 d 14 h rgentlem /trunk/src/main/ fixed an inefficiency in pmatch that speeds it up about 30% - how well
that moves up the chain is not so clear; thanks to H. Pages for pointing
this out		  
47460 6414 d 23 h ripley /trunk/src/main/ code cleanup
SET_STRING_ELT should not set R_NilValue, but it does in subscript.c		  

←Prev12Next→

Show All